search

csachs / picohttpclient

A tiny, no-dependencies, header-only HTTP 1.1 client library for C++ (very, very alpha)
MIT License
4 stars 3 forks source link

added support for https (using openssl) #2

Open jrialland opened 2 years ago

csachs commented 2 years ago

Thanks for the branch! I'm currently quite busy, so some decision will need to be postponed; generally SSL support is obviously something extremely useful, however since it is security-related, it needs to be done very carefully; and it certainly increases picohttpclient's dependency footprint. My main concern currently would be certificate verification; if done improperly, mitm-attacks might become possible.

jrialland commented 2 years ago

You're welcome :) effectively I have implemented just the bare necessary in order to be able to query the https urls I needed for my own project, it surely cannot be considered production-ready, as you said.

If I ever find the need and the time to add the proper cert validation code, I'll improve on my pull request