search

csachs / pyproject-flake8

pyproject-flake8 (pflake8), a monkey patching wrapper to connect flake8 with pyproject.toml configuration
The Unlicense
174 stars 16 forks source link

Added pre-commit hook configuration #2

Closed agronholm closed 3 years ago

agronholm commented 3 years ago

This allows pyproject-flake8 to be used as a pre-commit hook.

csachs commented 3 years ago

Thank you @agronholm for the contribution!

agronholm commented 3 years ago

Thanks!

agronholm commented 3 years ago

This still needs a new tag before it's usable with pre-commit.

csachs commented 3 years ago

I cleared my pre-commit cache and did not run into this issue; sorry; I've created a new tag v0.0.1a2.post1 .

agronholm commented 3 years ago

What's with the conservative versioning? It works, right? Maybe this should follow flake8 versioning with .postX added to it?

agronholm commented 3 years ago

But yeah, thanks for adding the tag. Pre-commit complains (rightfully) unless a specific version is used.

csachs commented 3 years ago

The point is, that currently pyproject-flake8 does not specify any specific flake8 version, it will just depend on the most recent one. Theoretically, flake8 versions could be fixed in pyproject-flake8 …