Activate coverage report via Github Actions

csaf-poc / csaf_webview

Web app (module) to display a CSAF 2 document and to browse CSAF 2 ROLIE feeds. ⚠️ The web demo is often not allowed to access servers:

https://csaf-poc.github.io/csaf_webview/

1 stars 3 forks source link

Activate coverage report via Github Actions #2

Closed ThomasJunk closed 6 months ago

ThomasJunk commented 11 months ago

Perhaps this is what we are looking for. https://github.com/csaf-poc/csaf_webview/commit/dbc62ed67dda0be719014001a0f881385f99a50b established the gathering of related data.

tschmidtb51 commented 11 months ago

Please make sure this also works with PRs from forks. We had an issue in a different repo that came up with a solution.

JanHoefelmeyer commented 7 months ago

Currently: The coverage report will always be created, however, the vitest coverage report we use needs to be modified for the proposed solution to work, which has not been done yet and might take a bit more time. As such, there is no comment yet on forked PRs. (The Coverage report can still be viewed within the action report)

JanHoefelmeyer commented 6 months ago

As described in https://github.com/davelosert/vitest-coverage-report-action/issues/300, vitest included a solution. This was added in https://github.com/csaf-poc/csaf_webview/commit/8289c2f11e5509b8203fa86857305652d4734adf and confirmed successful via https://github.com/csaf-poc/csaf_webview/pull/42 .

As such, I'd consider this issue as solved now.