csailer / bots

Automatically exported from code.google.com/p/bots
0 stars 0 forks source link

removed 'charset' from channel #166

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Charset in channel was used for:
1. display in filer
2. check charset send with charset of file

For 1., do more guessing now (was never 100%, this is not possible).
For 2.: this was not nice. Ran ito this often, AFAIK no added value.

In general, charset in channel was confusing. Looked like this determined 
something of the incoming file, which it did not.

NOTE: charset of edi-file is determined by either:
1. grammar, 
2. or explicit charset in incoming file. 
If bots knows the charset, display in filer is correct.

Original issue reported on code.google.com by hjebb...@gmail.com on 28 Aug 2012 at 11:49

GoogleCodeExporter commented 9 years ago
I like this... charset on channel was always confusing to me why it is needed, 
sometimes need multiple channels to the same location with different charsets.

Original comment by mjg1964 on 26 Sep 2012 at 1:06

GoogleCodeExporter commented 9 years ago
yes, it is confusing.

I am somewhat surprised by this, as the charset used is quite important IMHO
but now this was just working as  an annoying check afterwards.

Original comment by hjebb...@gmail.com on 26 Sep 2012 at 1:26

GoogleCodeExporter commented 9 years ago

Original comment by hjebb...@gmail.com on 31 Mar 2013 at 11:49

GoogleCodeExporter commented 9 years ago

Original comment by hjebb...@gmail.com on 10 Sep 2013 at 12:45