csainty / node-raven

RavenDB client for Node
csainty.github.com/node-raven
MIT License
13 stars 9 forks source link

patchGlobal() doesn't re-raise exceptions #3

Closed NachoSoto closed 12 years ago

NachoSoto commented 12 years ago

This might very well be a feature so I might need to implement this myself in my application, but I'm not really sure how to approach it. Basically, patchGlobal() will capture uncaught exceptions and send them to Sentry. From nodejs documentation (http://nodejs.org/api/process.html#process_event_uncaughtexception ):

If you do use it, restart your application after every unhandled exception!

So not quitting the process after this, can potentially leave the application in an unstable state. I've tried to wait for the captureError callback to do process.exit(1);, but I couldn't consistently make sure the exception was received by Sentry.

Am I missing something here? I feel like there's an easy way of solving this, but I just can't think of any.

NachoSoto commented 12 years ago

Wrong repository. Sorry