search

csandman / chakra-react-select

A Chakra UI themed wrapper for the popular library React Select
https://www.npmjs.com/package/chakra-react-select
MIT License
775 stars 33 forks source link

fix: import chakraui/icon #277

Closed jonashger closed 1 year ago

jonashger commented 1 year ago

Closes #276

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d8efd3c7d89b69fd16dbbacc013d8268085eb7a:

Sandbox Source
chakra-react-select demo Configuration
chakra-react-select TS demo Configuration
chakra-react-select + next.js Configuration
chakra-react-select + next.js + typescript Configuration
bujarinnovationnorway commented 1 year ago

Could we merge this quickly? I am in the process of releasing my app and this came at the worst time possible.

csandman commented 1 year ago

I think that it's wrong to include more than once the same package. "'@chakra-ui/icon' import is duplicated". It shouldn't be like this? import { Icon, IconProps } from '@chakra-ui/icon';

There's nothing wrong with this when one of the top level imports is import type { by the way. It wasn't even possible to do an inline import { type... until more recently.