Return `Bool*` for logical expr in IrBuilder

csarofeen / pytorch

Tensors and Dynamic neural networks in Python with strong GPU acceleration

http://pytorch.org

Other

26 stars 7 forks source link

Return `Bool*` for logical expr in IrBuilder #2494

Closed zasdfgbnm closed 1 year ago

zasdfgbnm commented 1 year ago

By using newLogicExpr, we are already assuming Bool*, so I don't see any reason why not to return a Bool* because doing so can be more convenient to use.

naoyam commented 1 year ago

On a slightly related note, do you think we can remove SimplyfingIrBuilder in favor of the expression simplifier?