csarofeen / pytorch

Tensors and Dynamic neural networks in Python with strong GPU acceleration
http://pytorch.org
Other
26 stars 7 forks source link

Fixing and improving indexing type handling #2522

Closed mmigdal-nv closed 1 year ago

mmigdal-nv commented 1 year ago

Fixed issues:

Improvements:

Changes:

mmigdal-nv commented 1 year ago

In the case of matmuls, this happens to fix the cases where:

naoyam commented 1 year ago

As I mentioned to @mmigdal-nv, I think the fix of this PR is sufficient. As long as a fusion is executed through FusionExecutorCache, we should not see back-and-forth recompilations due to index mode changes. The only request I have for @mmigdal-nv is to add a simple C++ test that verifies this behavior. https://github.com/csarofeen/pytorch/pull/2522#discussion_r1119341798