search

csarrazi / CsaGuzzleBundle

A bundle integrating Guzzle >=4.0 in Symfony
250 stars 77 forks source link

Autoconfigure support #225

Closed backbone87 closed 6 years ago

backbone87 commented 6 years ago

It would be nice if the ClientInterface is registered for autoconfiguration (symfony 3.3+)

ref https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L280

csarrazi commented 6 years ago

I also agree. That would be a nice addition, after support for auto wiring.

One thing though, I am not sure whether this would not introduce a breaking change, so I would rather present a new config entry (‘csa_guzzle.autoconfigure’), which would be set to false in version 3.1.

For version 4.0, the value will be switched to ‘true’, or even removed to enable auto config by default.

backbone87 commented 6 years ago

the tag would applied to services with autoconfigure="true" only, which is a symfony 3.3/3.4+ feature

tgalopin commented 6 years ago

I think this can be closed now.