Fix: Remove cache-related service definitions when cache is disabled

csarrazi / CsaGuzzleBundle

A bundle integrating Guzzle >=4.0 in Symfony

250 stars 77 forks source link

Closed localheinz closed 5 years ago

localheinz commented 6 years ago

This PR

[x] asserts that cache-related service definititions are removed from container when cache is disabled
[x] removes cache-related service definititions from container when cache is disabled

csarrazi commented 5 years ago

Thanks @localheinz It seems that one test still doesn't pass. Could you fix it, so I can merge your PR?

By the way, as a reminder, version 1.x is no longer supported, so you should consider migrating to version 3.x of the bundle :)

localheinz commented 5 years ago

@csarrazi

Ha, we're currently in the process of migrating a project to newer PHP versions, will update as soon as we are finished!

csarrazi commented 5 years ago

Thanks @localheinz !

localheinz commented 5 years ago

Thank you, @csarrazi!