search

csarrazi / CsaGuzzleBundle

A bundle integrating Guzzle >=4.0 in Symfony
250 stars 76 forks source link

fix twig extension deprecation (since Twig 2.7). #245

Closed hervems closed 5 years ago

hervems commented 5 years ago
Q A
Bug fix? [no]
New feature? [no]
BC breaks? yes]
Deprecations? [yes]
Tests pass? [yes]
Fixed tickets []
License Apache License 2.0
csarrazi commented 5 years ago

Thanks for the pull request. Are we certain that Twig 1.x is no longer maintained? Do we know when Twig_SimpleFilter will be actually removed from Twig? (I suspect Twig 3.x, but I want to confirm).

csarrazi commented 5 years ago

Please note that because of the removal of the Twig 1.x dependency, this would be a BC break, hence justifying an upgrade of the bundle's major version.

hervems commented 5 years ago

Yes, effectively, it's a BC here, but I think it's a good practice to be up to date, at least, to propose a version without trigger_error message. In my case, we can't pass Travis CI just for that.

csarrazi commented 5 years ago

In that case, can you raise the branch alias for master to 4.0-dev?

Thanks

hervems commented 5 years ago

Yes, I'm ok for that. Thanks

csarrazi commented 5 years ago

I'll merge this as soon as you update the branch-alias :)

csarrazi commented 5 years ago

Thanks @hervems!