csarrazi / CsaGuzzleBundle

A bundle integrating Guzzle >=4.0 in Symfony
250 stars 76 forks source link

Symfony 5 support #255

Closed rvanlaak closed 4 years ago

rvanlaak commented 4 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License Apache License 2.0

Allow installing bundle with Symfony 5.0

Appveyor fix borrowed from https://github.com/symfony/symfony/commit/6194c2a96c6c8c35de8929a95a3f498941cd1760

csarrazi commented 4 years ago

Thanks @rvanlaak !

rvanlaak commented 4 years ago

You are welcome! Time for some tagging 🎉

Could you also share some insights on why the middleware classes are separate repos? Given that they also all require Symfony they aren't that portable. I even think the Symfony dependencies could get removed for these repos?

csarrazi commented 4 years ago

The rationale for this is that Guzzle is not part of the Symfony project, and other projects want to use the middleware, without necessarily fetch every single dependency.

rvanlaak commented 4 years ago

@csarrazi is there work to be done before a new minor can get tagged?

csarrazi commented 4 years ago

Not really. It's just that I no longer have a personal laptop, so I won't be able to push tags until I find some time to set up something on another machine.

rvanlaak commented 4 years ago

Github allows creating tags directly 🎉:

https://github.com/csarrazi/CsaGuzzleBundle/releases/new

csarrazi commented 4 years ago

True, but from what I recall, GitHub only creates lightweight tags, and not annotated tags (which are signed and associated to an author). I'll do that in the upcoming days, once I manage to find some time! :)

rvanlaak commented 4 years ago

Great! Let us know when you need help 💪

Surf-N-Code commented 4 years ago

Sorry to bug you on this, but did you find the time yet? :) @csarrazi

rvanlaak commented 4 years ago

@csarrazi can you tag the new version?

mvorisek commented 4 years ago

@csarrazi Can a new tagged release be made to reflect this merged PR?

csarrazi commented 4 years ago

New release tagged