Closed rvanlaak closed 4 years ago
Thanks @rvanlaak !
You are welcome! Time for some tagging 🎉
Could you also share some insights on why the middleware classes are separate repos? Given that they also all require Symfony they aren't that portable. I even think the Symfony dependencies could get removed for these repos?
The rationale for this is that Guzzle is not part of the Symfony project, and other projects want to use the middleware, without necessarily fetch every single dependency.
@csarrazi is there work to be done before a new minor can get tagged?
Not really. It's just that I no longer have a personal laptop, so I won't be able to push tags until I find some time to set up something on another machine.
Github allows creating tags directly 🎉:
True, but from what I recall, GitHub only creates lightweight tags, and not annotated tags (which are signed and associated to an author). I'll do that in the upcoming days, once I manage to find some time! :)
Great! Let us know when you need help 💪
Sorry to bug you on this, but did you find the time yet? :) @csarrazi
@csarrazi can you tag the new version?
@csarrazi Can a new tagged release be made to reflect this merged PR?
New release tagged
Allow installing bundle with Symfony 5.0
Appveyor fix borrowed from https://github.com/symfony/symfony/commit/6194c2a96c6c8c35de8929a95a3f498941cd1760