csc301-2023-fall / project-34-qeynet-inc-t

Repository for Astra, a U of T CSC301 team project developed for QEYnet.
MIT License
0 stars 1 forks source link

Make things more consistent with Panoptes #38

Open shape-warrior-t opened 8 months ago

shape-warrior-t commented 8 months ago

The logical event base classes AllEventBase and AnyEventBase can probably be renamed to the more clear LogicalAndEventBase and LogicalOrEventBase, as they are in the team's version of Panoptes. There's also some other differences in terminology between the two codebases: SimpleEventBase, CompoundEventBase, and Parameter for Astra corresponding to SingleTagEventBase, MultiTagEventBase, and TagEntry in Panoptes. I intentionally chose the former names because they made more sense to me; change (or don't change) names according to your best judgement.

(Also, the tags key of compound event bases in the autogenerated config files is currently ignored entirely in favour of recursively constructing the tags for a compound event base based on the tags of the inner event bases. Should probably either remove that key entirely or actually use it to determine the tags.)