search

csc302-spring-2021 / proj-DaTeam

CSC302 course project for DaTeam
https://dateam-frontend.herokuapp.com/
5 stars 2 forks source link

feat: FormResponseValidator #121

Closed Timmarus closed 3 years ago

Timmarus commented 3 years ago

Description

Checklist

QA Steps

  1. cd shared && npx tsc && npm run test Expected outcome: No errors under the "Validator test" heading.

If you want to QA vigorously, you can create your own mock form and formresponse to validate specific errors.

Timmarus commented 3 years ago

Looks like Test.ts conflicts since it was deleted recently, looking into adding it into the new tests framework.

DiademShoukralla commented 3 years ago

QA

Not doing steps mentioned in the description since Tests.ts is removed from a different ticket. Unit testing for the Form Validation will be covered in #112 .

QA will just be a sanity test. Run the following:

npm run clean
npm run clean:ci
npm i
npm run docker:build
npm run docker:up

Verify services run as expected ✔️ Note: For some reason, frontend-local exited with code 1; "frontend-local | standard_init_linux.go:219: exec user process caused: no such file or directory". However, since this changeset is unrelated to front end (and since Front end CI passes) and because backend and shared services works as expected, this is a QA PASS.