cscheid / rgithub

R bindings for the github API
MIT License
70 stars 31 forks source link

ellipsis vs content parameters #59

Closed cscheid closed 6 years ago

cscheid commented 9 years ago

We're going to need to break some behavior in rgithub to fix this, but there's inconsistencies across the API. Some call use ellipsis for the body of a request, like create.repository:

create.repository <- function (..., ctx = get.github.context()) 
  .api.post.request(ctx, c("user", "repos"), body = list(...))

But some calls use a content parameter:

modify.repository <- function(owner, repo, content, ctx = get.github.context())
  .api.patch.request(ctx, c("repos", owner, repo), body=content)

We should pick one of these and go with it.

cscheid commented 6 years ago

Closed (wontfix) by #70.