Open krlmlr opened 8 years ago
This one requires a bit more careful of a review, and it's unlikely I'll get to it before thursday or so next week. Ok?
This needs a bit of work from me, I just wanted to know if you like the design or if you prefer something completely different.
Oof, this completely fell off the radar for me. Thanks for the bump. I'll be looking at it this week.
@jennybc, since you're a user of rgithub and a much better R developer than me, I'd love to hear your thoughts on this PR.
Just tried it again for pull requests, still works for me.
Rough draft for pagination as suggested by @jennybc.
Use case:
This is strictly in a "works for me" state. Possible extensions:
fetch.page(page = "next")
, also allow specifying a page numberfetch.all.pages()
asstraightforwardextension (needs argwarn = FALSE
infetch.page()
)get.page.count(request)
so thatfetch.all.pages()
can show a progress barDo we want to follow the approach sketched here?
Fixes #30.