don't break on vectors with other attributes like 'class'

cscheid / rserve-js

Javascript implementation of the Rserve protocol

MIT License

47 stars 32 forks source link

don't break on vectors with other attributes like 'class' #18

Closed s-u closed 10 years ago

s-u commented 10 years ago

Generic vectors with any attributes other than "names" will break (e.g. I(list())). This patch makes sure they don't , but see FIXME comments inside - ideally, names should be handled properly by looking for the "names" attribute.

cscheid commented 10 years ago

Thanks for the review and fix. this tells you about my knowledge of the R internals...