cscheid / rserve-js

Javascript implementation of the Rserve protocol
MIT License
47 stars 32 forks source link

bounds checking for one case in dataview #23

Closed gordonwoodhull closed 9 years ago

gordonwoodhull commented 9 years ago

probably there are other places where this is needed, but this one had a FIXME comment, and it helps diagnose problems we are seeing with messages apparently being broken into frames/fragments

gordonwoodhull commented 9 years ago

@s-u, this helps diagnose the bounds problems we are seeing in https://github.com/att/rcloud/issues/1133 (clever breakpoints also help)

cscheid commented 9 years ago

Looks good. Thank you.

gordonwoodhull commented 9 years ago

Thanks! We also use #22 in current rcloud, in order to communicate with compute and control processes.

cscheid commented 9 years ago

Ok.

I’ll fix the tabs over the weekend and merge.=