search

cscherrer / Soss.jl

Probabilistic programming via source rewriting
https://cscherrer.github.io/Soss.jl/stable/
MIT License
414 stars 30 forks source link

Fix issue with optional loading of SampleChainsDynamicHMC #300

Closed sethaxen closed 2 years ago

sethaxen commented 2 years ago

Before this PR:

julia> using Soss

julia> using SampleChainsDynamicHMC
┌ Warning: Package Soss does not have SampleChainsDynamicHMC in its dependencies:
│ - If you have Soss checked out for development and have
│   added SampleChainsDynamicHMC as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with Soss
└ Loading SampleChainsDynamicHMC into Soss from project dependency, future warnings for Soss are suppressed.

With this PR:

julia> using Soss

julia> using SampleChainsDynamicHMC
codecov[bot] commented 2 years ago

Codecov Report

Merging #300 (4d1e556) into master (5acf2ca) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   30.61%   30.61%           
=======================================
  Files          49       49           
  Lines        1202     1202           
=======================================
  Hits          368      368           
  Misses        834      834
Impacted Files Coverage Δ
src/samplechains/dynamichmc.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5acf2ca...4d1e556. Read the comment docs.

cscherrer commented 2 years ago

Thanks! Let's get this in right away once tests are done