search

cscherrer / SossMLJ.jl

SossMLJ makes it easy to build MLJ machines from user-defined models from the Soss probabilistic programming language
https://cscherrer.github.io/SossMLJ.jl/stable/
MIT License
15 stars 1 forks source link

Don't re-export Soss #115

Closed DilumAluthge closed 3 years ago

DilumAluthge commented 3 years ago

I almost merged https://github.com/cscherrer/SossMLJ.jl/pull/114 by accident without dropping support for Soss 0.14.

It occurs to me that it will get annoying to have to remember to always manually edit the CompatHelper PRs to drop support for the old version of Soss.

The reason that we always have to drop the old version of Soss is because we re-export Soss. If we stop re-exporting Soss, we no longer need to do this, and we can support multiple breaking releases of Soss in the same version of SossMLJ.

So this PR stops exporting SossMLJ.

I think it's fine to just tell users to add using Soss at the top of their files.

cc: @cscherrer

codecov-commenter commented 3 years ago

Codecov Report

Merging #115 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines           96        96           
=========================================
  Hits            96        96
Impacted Files Coverage Δ
src/SossMLJ.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a53014f...4848d7e. Read the comment docs.