Devise::Authenticatable is misspelled thus breaking gem

[acurley]

Current spelling is Autheneticatable, which produces a NameError on startup. This typo breaks the gem.

[gustaflindqvist]

Good working on finding the misspelled class name @acurley! I hope it gets merge ASAP.

[acurley]

@gustaflindqvist, unfortunately I was the person who caused the misspelling in my last PR! :(

[gustaflindqvist]

@acurley I think it's time for devise_ldap_authenticatable to not working against master to get the latest version of the gem. Time to update the version tag and create releases, maybe?

Latest release is 0.6.1 and the master is on version 0.8.3 (or whatever...) :disappointed:

[acurley]

@cschiewek, what do you think? Send a new release to rubygems so we can stop working against master to get the most up to date code?

[cschiewek]

Just merged. Pushing to rubygems shortly.

[gustaflindqvist]

@cschiewek Awesomeness!

[cschiewek]

v0.8.3 is now live on rubygems

[gustaflindqvist]

@cschiewek then I finally can add:

gem 'devise_ldap_authenticatable', '0.8.3'

Better for the production server. :+1:

[acurley]

@cschiewek Thanks so much! :+1:

[cschiewek]

You're welcome! :)

On Thu, 19 Mar 2015 at 12:07 Andrew Curley notifications@github.com wrote:

@cschiewek https://github.com/cschiewek Thanks so much! [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/cschiewek/devise_ldap_authenticatable/issues/195#issuecomment-83645041 .

[drobny]

@cschiewek Thanks for pulling this in. I also noticed that the previous merge assumed that find_for_ldap_authentication always returns a resource object but it could be nil if auth keys are left blank. I made a pull request #193 that sorts this as well. Might not be relevant so sorry if I am butting in!

[cschiewek]

I pulled it in as well. So your change is in master and will be in the next gem release.

If any of you are using this on a regular basis and would like to help contribute, let me know and I'll give you rights on the repo. We've moved away from LDAP to SAML, so I'm not using much anymore and would love help from folks who are using it day to day.

[acurley]

@cschiewek I and my team use this gem in all of our applications. I would love to help out with the maintenance burden.

[cschiewek]

@acurley I've just added you as a contributor. Do you have a rubygems account? If so, let me know what it is and I'll give you publishing rights there as well.

[gustaflindqvist]

Me too! 

— Sent from Mailbox

On Thu, Mar 19, 2015 at 6:00 PM, Andrew Curley notifications@github.com wrote:

@cschiewek I and my team use this gem in all of our applications. I would love to help out with the maintenance burden.

Reply to this email directly or view it on GitHub: https://github.com/cschiewek/devise_ldap_authenticatable/issues/195#issuecomment-83663293

[cschiewek]

Done! If you guys have the time, it would be great if we could clear up the backlog somewhat. I'm willing to guess a bunch of those issues are non-starters and just need to be closed.

[acurley]

Agreed. I will start taking a look this evening (US Eastern)