search

cschiewek / devise_ldap_authenticatable

Devise Module for LDAP
MIT License
593 stars 359 forks source link

Remove testing dependency on openldap #197

Open cschiewek opened 9 years ago

cschiewek commented 9 years ago

Attn: @acurley @gustaflindqvist

I'd like to remove the openldap dependency from the test suite. This would allow us to setup on travis and greatly simplify the test suite in general.

I think https://github.com/NUBIC/ladle would facilitate this, but haven't done any significant investigation into it.

Let me know your thoughts...

acurley commented 9 years ago

I think your idea is correct. Our friends at Github use ladle for testing apps that they integrate with their repo github-ldap. But on travis, they use openldap. Travis allows you to install packages and numerous ldap related projects have a script, invoked during the install section of the build lifecycle, that installs openldap.
https://github.com/github/github-ldap/blob/master/.travis.yml and https://github.com/github/github-ldap/blob/master/script/install-openldap

Perhaps that is the best first step?

gustaflindqvist commented 9 years ago

Yeah, I agrees. Good first step. 

— Sent from Mailbox

On Thu, Mar 19, 2015 at 6:59 PM, Andrew Curley notifications@github.com wrote:

I think your idea is correct. Our friends at Github use ladle for testing apps that they integrate with their repo github-ldap. But on travis, they use openldap. Travis allows you to install packages and numerous ldap related projects have a script, invoked during the install section of the build lifecycle, that installs openldap.
https://github.com/github/github-ldap/blob/master/.travis.yml and https://github.com/github/github-ldap/blob/master/script/install-openldap

Perhaps that is the best first step?

Reply to this email directly or view it on GitHub: https://github.com/cschiewek/devise_ldap_authenticatable/issues/197#issuecomment-83694835

cschiewek commented 9 years ago

:+1: