cschiewek / devise_ldap_authenticatable

Devise Module for LDAP
MIT License
593 stars 359 forks source link

Revert "Use admin_as_user to authenticate admin role by user login param... #202

Closed renchap closed 7 years ago

renchap commented 9 years ago

Reverts cschiewek/devise_ldap_authenticatable#165

165 added an unwanted README change, did not updated the doc or the default config files (this broke tests, cf #201), and I havent managed to get it working (when using admin_as_user as intended, login and password are not set when opening a LDAP connection as an admin.

Without it, all works correctly using ldap_check_group_membership_without_admin and you get the expected behavior the user initially wanted.

A version bump after merging this would be a good idea as the gem is currently broken when you try to use the user connection as the admin one, as per the docs.

Sankarshan-Mudkavi commented 8 years ago

Are there any updates to this? We are also experiencing issues with the unit tests on the current master.