cschiller / zhongwen

Official source code of the "Zhongwen" Chrome extension
https://chrome.google.com/webstore/detail/zhongwen-chinese-english/kkmlkkjojmombglmlpbpapmhcaljjkde
GNU General Public License v2.0
312 stars 52 forks source link

Add support to capture the sentence of the word #21

Closed p2635 closed 7 months ago

p2635 commented 5 years ago

It would be very useful if this could be added. Basically when I save words, I also want to know what the sentence it was in. Perhaps some clever regex stuff might be required to determine what a sentence actually is. Then when I export it, I have a whole list of sentences that can go into Anki.

cschiller commented 4 years ago

With version 5.6.0 you can now add notes to the individual entries in the built-in word list. You can paste in the original sentence there.

webmagnets commented 4 years ago

With version 5.6.0 you can now add notes to the individual entries in the built-in word list. You can paste in the original sentence there.

It sure would be nice if it did it automatically.

cschiller commented 4 years ago

It sure would be nice if it did it automatically.

The problem is how to identify the sentences. A lot of web pages contain Chinese text that is not part of a sentence. I think adding the sentence manually is an acceptable compromise.

p2635 commented 3 years ago

Would a very rough way to do it to simply detect a full stop before and after the target word? Better than nothing right?

ExlangBrett commented 3 years ago

I would like to add functionality to try and capture a sentence, and then export the highlighted word and sentence to flashcards. I have an idea that we could use a templated format to build a variety of flashcards from the same content to support fluency building. Examples include pinyin to the character and vice versa(just the highlighted word), English to Chinese and vice versa (just the highlighted word), and then fill in the blank with the full sentence etc. I think building fluency in the context of the original sentence would be helpful for learners...

@p2635 and @webmagnets does this sound useful for what you were looking for, if we can overcome the sentence parsing issues?

@cschiller I have never contributed to a Github projects before. How do I coordinate if this is ok to do? I sent you an email to the email on file at the Chrome extension store

-Thanks - Brett

cschiller commented 3 years ago

Hi @ExlangBrett, I would suggest you fork the repo and implement your suggestion. Then I have a better idea what you mean specifically and we can discuss it.

ExlangBrett commented 3 years ago

Hi @ExlangBrett, I would suggest you fork the repo and implement your suggestion. Then I have a better idea what you mean specifically and we can discuss

Thanks for getting back to me @cschiller! I don't have the code available as I'm not a developer, but I have graphic design that might help show what I mean. Here is a pdf on my google drive:

https://drive.google.com/file/d/18mlP0zkMRSIVjAaF4ieZxhqGzcYnoCgy/view?usp=sharing

So, the flashcards show the hypothetical that if I was reading on the internet and used the zhongwen plugin to look up two words in the same sentence, "他的歌传遍大街小巷,你会在校园小路、宿舍楼道、人行道、橱窗前以及每一个可以放音乐的大喇叭里听到他的音乐。" The words I might look up are "人行道" and "喇叭".

If we could successfully import the sentence with the vocabulary words then we could simply use the template of the flashcards to create the 14 flashcards in the PDF to allow users to gain fluency with the vocabulary within the context of the sentence they looked them up in.

We could start with just the cards that have the vocabulary words if parsing the sentence turns out to be difficult.

If this idea seems like you might allow it as an addition feature of zhongwen then I'll work on how we might be able to get the code in another branch for you to see.

Thanks,

Brett

ExlangBrett commented 2 years ago

Hi @ExlangBrett, I would suggest you fork the repo and implement your suggestion. Then I have a better idea what you mean specifically and we can discuss it.

@cschiller - do the graphic prototypes in the link above give you an idea of what I'm thinking about doing? Pages 7 and 8 show what the sentence context would be used for in this case.

cschiller commented 2 years ago

Hi @ExlangBrett, if you implement it (or find somebody who implements it for you) I will take a look at it and consider merging a pull request. But I cannot guarantee it.