search

cschiller / zhongwen

Official source code of the "Zhongwen" Chrome extension
https://chrome.google.com/webstore/detail/zhongwen-chinese-english/kkmlkkjojmombglmlpbpapmhcaljjkde
GNU General Public License v2.0
312 stars 52 forks source link

Adding content.js to be available under Devtools #77

Closed metzkorn closed 3 years ago

metzkorn commented 3 years ago

Image of Developer Panel I've liked this extension for the ease of not having to commit to a google search each time I want to look up a word's pinyin. The translation has been helpful, but as an immersion learner, I want to remove it. I'm not sure how this is implemented, but content.js isn't on the DevTool panel while dict.js and background.js are (and I'm curious as to why / how this works). I'm sure I can find a way to remove the English in the dict.js section, but I already understand how to modify content.js for the same result. I'll probably just work around this issue by finding a modification in dict.js or cloning the repository, changing content.js myself, and installing the software as a new plugin. 同学们加油！

metzkorn commented 3 years ago

Seems like this has to do with DevTools not recognizing the manifest file (which is where content.js is called), so I don't think this is something Christian needs to workaround as a hack-fix convenience for me. I'm closing the issue.