implements fix and tests for bug - Githubissues

cschlaffner / PROTzilla2

13 stars 1 forks source link

implements fix and tests for bug #466

Closed JanniRoebbecke closed 5 months ago

JanniRoebbecke commented 5 months ago

Description

fixes #465

issue was fixed and tests where adapted

Changes

tests where adapted to detect this issue should it occur again
by_proteins_missing was adapted, so it does not ignore samples with nan values for all Proteins

Testing

the adapted tests for by_proteins_missing can be used to test the correct behavior

PR checklist

Development

[x] If necessary, I have updated the documentation (README, docstrings, etc.)
[x] If necessary, I have created / updated tests.

Mergeability

[x] main-branch has been merged into local branch to resolve conflicts
[x] The tests and linter have passed AFTER local merge
[x] The code has been formatted with black

Code review

[x] I have self-reviewed my code.
[x] At least one other developer reviewed and approved the changes

github-actions[bot] commented 5 months ago

Coverage report

This PR does not seem to contain any modification to coverable code.