469 bug tests show figures - Githubissues

cschlaffner / PROTzilla2

12 stars 0 forks source link

469 bug tests show figures #470

Closed JanniRoebbecke closed 2 months ago

JanniRoebbecke commented 2 months ago

Description

fixes #469

fixes all tests that failed when tests where run with show figures

Changes

Five tests failed because the tested method returns a list containing the a plot, but the test expected to get just the plot without a list-wrapper. These tests where fixed by adding a [0] to extract the first item of the list (i.e. the plot).
return types where specified for the plot methods to avoid similar mistakes in the future
One test failed because the tested plot generation method was not given suitable parameters and thus did not return a plot. This was fixed by changing the parameters given to the tested Method.

Testing

Run all tests with additional argument show figures

PR checklist

Development

[x] If necessary, I have updated the documentation (README, docstrings, etc.)
[x] If necessary, I have created / updated tests.

Mergeability

[x] main-branch has been merged into local branch to resolve conflicts
[x] The tests and linter have passed AFTER local merge
[x] The code has been formatted with black

Code review

[x] I have self-reviewed my code.
[x] At least one other developer reviewed and approved the changes

github-actions[bot] commented 2 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
protzilla/data_analysis
plots.py
Project Total

This report was generated by python-coverage-comment-action