cschlaffner / PROTzilla2

12 stars 0 forks source link

Improve error handling to only handle specific errors, also print sta… #507

Closed henninggaertner closed 1 week ago

henninggaertner commented 2 weeks ago

Description

fixes #505 Basically, improved the read_run function and the ErrorHandler wrapper. Now the stacktrace is printed if in debug mode, and also if a step cannot be read, a logging warning is produced, but the rest of the steps are read, preventing the yellow screen of death.

Changes

only in disk_operator.py

Testing

Change the step_type of a valid run, or whatever you want to make the reading of that step fail, and see how that step does not appear in the run anymore, but the rest of the run is read correctly.

PR checklist

Development

Mergeability

Code review

github-actions[bot] commented 2 weeks ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  disk_operator.py 20-21, 35, 114-116
  protzilla/data_preprocessing
  filter_proteins.py
  outlier_detection.py
  peptide_filter.py
  transformation.py
  protzilla/importing
  peptide_import.py
  protzilla/methods
  data_preprocessing.py
  importing.py 142
Project Total  

This report was generated by python-coverage-comment-action