search

cschlosser / drone-ftps

Deploy to FTPS server from Drone CI build
https://hub.docker.com/r/cschlosser/drone-ftps/
Apache License 2.0
20 stars 16 forks source link

add verify SSL option #4

Closed servusoft closed 6 years ago

servusoft commented 6 years ago

done,. the typo is gone and default values are documented..

cschlosser commented 6 years ago

Thank you for your work. Could you please add your new option to the offficial drone plugin documentation (https://github.com/drone/drone-plugin-index)

servusoft commented 6 years ago

look please here: https://github.com/servusoft/drone-plugin-index/blob/master/content/christophschlosser/drone-ftps/index.md if the descritption is Ok, I make a PR.

cschlosser commented 6 years ago

"transfer will fails due the certificat validation.. " transfer will fail due to the certificate validation. "In this case the validation may be suppressed:" In this case the validation may be skipped: "The SSL encryption mey be disabled, if the FTP server not supports SSL." The SSL encryption may be disabled, if the FTP server does not support SSL.

I found a few typos. These are my suggestions to correct them. Otherwise it looks good, feel free to make a PR.

Thanks for your work

servusoft commented 6 years ago

thaks, the PR is created, but I have no reaction: https://github.com/drone/drone-plugin-index/pull/90

I think, its, better, you make the PR.

cschlosser commented 6 years ago

Give it some time. If there's no reaction til next week we'll see what we can do.