search

cschramm / irda

36 stars 8 forks source link

Build fails if CONFIG_PPP is disabled #5

Closed mirage83-ger closed 2 years ago

mirage83-ger commented 2 years ago

The build of the modules fails if the CONFIG_PPP kernel option is disabled.

cschramm commented 2 years ago

Any more details? https://app.circleci.com/pipelines/github/cschramm/irda is actually building the default modules without CONFIG_PPP set.

mirage83-ger commented 2 years ago

Following patch fixes the issue:

--- src/net/Kbuild
+++ src/net/Kbuild
@@ -6,7 +6,9 @@

 obj-m += irda.o
 obj-m += irlan/
-obj-m += irnet/
+ifdef CONFIG_PPP
+  obj-m += irnet/
+endif
 obj-m += ircomm/

 irda-y := iriap.o iriap_event.o irlmp.o irlmp_event.o irlmp_frame.o \
cschramm commented 2 years ago

Building net/irnet/irnet.ko without CONFIG_PPP set works fine for me with Linux versions 5.18 and 5.19.

mirage83-ger commented 2 years ago

I'm getting the following build error:

  MODPOST ../irda/src/Module.symvers
ERROR: modpost: "irlmp_get_discoveries" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "single_open" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "ppp_unit_number" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "single_release" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "ppp_unregister_channel" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "ppp_output_wakeup" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "misc_register" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "hashbin_find" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "_ctype" [../irda/src/net/irnet/irnet.ko] undefined!
ERROR: modpost: "mutex_lock_interruptible" [../irda/src/net/irnet/irnet.ko] undefined!
WARNING: modpost: suppressed 10 unresolved symbol warnings because there were too many)
scripts/Makefile.modpost:134: recipe for target '../irda/src/Module.symvers' failed
make[1]: *** [../irda/src/Module.symvers] Error 1

The symbols are not included in the kernel if CONFIG_PPP is not set.

cschramm commented 2 years ago

Fixed. Thanks! I have no idea why the build works fine for the defconfig test build. :confused: