New <Text> component is missing factory and recipe

cschroeter / park-ui

Beautifully designed components built on Ark UI that work for the JS and CSS frameworks of your choice.

https://park-ui.com

MIT License

1.47k stars 59 forks source link

New <Text> component is missing factory and recipe #308

Closed alanhoff closed 1 month ago

alanhoff commented 1 month ago

Hey, it looks like the new <Text /> component isn't being wrapped by the jsx factory with styled() and it's also not using the text recipe anymore. This causes all the JSX style props to just be forwarded into <Component />. Is that correct?

https://github.com/cschroeter/park-ui/commit/b809d7a11ec96f312fafef671f5b16f19debe4ce#diff-2b780ab533590cf97f45a899095b095eb2cb695b01810b73719d8b767c6bc1ccR35

gal1419 commented 1 month ago

probably related to #311

marviobezerra commented 1 month ago

Same here

cschroeter commented 1 month ago

@alanhoff @gal1419 @marviobezerra

I had to rewrite the Text component to avoid using union intersection. Combining HTMLProps with JSXStyleProps across all possible HTML tags was too complex for TypeScript to handle. The updated component is now available for copy/fetch from the CLI.

gal1419 commented 1 month ago

Thanks @cschroeter!