search

cschroeter / park-ui

Beautifully designed components built on Ark UI that work for the JS and CSS frameworks of your choice.
https://park-ui.com
MIT License
1.47k stars 59 forks source link

CLI pulls components that are incompatible with Ark 2 #338

Open simoncollins opened 1 month ago

simoncollins commented 1 month ago

I have an existing code base using components installed previously and with a dependency on @ark-ui/react v2.2.x. Adding new components today (e.g Popover and Carousel) gives me source code that is only compatible with version 3 of Ark as they depend on new exports introduced in that version.

It would be preferable to have the CLI pull from a tag that is compatible with the version of Ark in use, even if it's just the major version. Obviously this is not a show stopper as I can just go and pull the versions pre the change for V3 from Github but it would improve the DX.

lilouartz commented 4 weeks ago

Experience the same issue

cschroeter commented 4 weeks ago

@simoncollins

Thanks for taking your time to share this issue. A quick fix for this would be to allow the CLI to accept an url endpoint so you could do sth like

npx @park-ui/cli --url <OLD_ENDPOINT> add pin-input
simoncollins commented 3 weeks ago

Thanks @cschroeter ... yeah that would work. I'll put up a PR for that in the next week or so.