Open kotsutsumi opened 2 weeks ago
The current logic is as follows
The loadingText continues to be displayed even when loading is specified as false.
{loading && !loadingText ? ( <> <ButtonSpinner /> <styled.span opacity={0}>{children}</styled.span> </> ) : loadingText ? ( loadingText ) : ( children )}
Therefore, it would be correct to implement as follows.
{loading && !loadingText ? ( <> <ButtonSpinner /> <styled.span opacity={0}>{children}</styled.span> </> ) : loading && loadingText ? ( loadingText ) : ( children )}
This way, children will be displayed if loadingText is specified and loading is false.
If the current implementation is correct, then this issue is an unnecessary point.
thx
The current logic is as follows
The loadingText continues to be displayed even when loading is specified as false.
Therefore, it would be correct to implement as follows.
This way, children will be displayed if loadingText is specified and loading is false.
If the current implementation is correct, then this issue is an unnecessary point.
thx