cschroeter / park-ui

Beautifully designed components built with Ark UI and Panda CSS that work with a variety of JS frameworks.
https://park-ui.com
MIT License
1.74k stars 75 forks source link

Button loading text is not changed to children when loading is false #463

Open kotsutsumi opened 2 weeks ago

kotsutsumi commented 2 weeks ago

The current logic is as follows

The loadingText continues to be displayed even when loading is specified as false.

{loading && !loadingText ? (
    <>
        <ButtonSpinner />
        <styled.span opacity={0}>{children}</styled.span>
    </>
) : loadingText ? (
    loadingText
) : (
    children
)}

Therefore, it would be correct to implement as follows.

{loading && !loadingText ? (
    <>
        <ButtonSpinner />
        <styled.span opacity={0}>{children}</styled.span>
    </>
) : loading && loadingText ? (
    loadingText
) : (
    children
)}

This way, children will be displayed if loadingText is specified and loading is false.

If the current implementation is correct, then this issue is an unnecessary point.

thx