search

cschwan / sage-on-gentoo

(Unofficial) Gentoo Overlay for Sage- and Sage-related ebuilds
84 stars 26 forks source link

ipython < 7 versions were removed from gentoo #575

Closed ngg closed 4 years ago

ngg commented 4 years ago

Currently there is no compatible ipython and sage versions in this overlay, I think sage should be patched to use ipython-7.

Here is a patch from Arch Linux for this: https://aur.archlinux.org/cgit/aur.git/tree/sagemath-ipython7.patch?h=sagemath-git (it's a really long patch, but most of it is only doctest fixes)

kiwifb commented 4 years ago

Darn. I was hoping they would stay in a bit longer. I know about the arch patch (and I know Antonio Rojas who work on sage-on-arch).

kiwifb commented 4 years ago

I was afraid of that. The main tree has ipython-7.5.0 but the latest arch patch is for 7.10. And yes there is an impact https://trac.sagemath.org/ticket/28197

kiwifb commented 4 years ago

I digged the previous patch from arch that is good for ipython-7.5. Testing things right now. There will be something in the overlay soon.

strogdon commented 4 years ago

It's probably known but with ipython-7.10.0 I'm unable to build the docs

ImportError: cannot import name '_baseclass_reprs' from 'IPython.lib.pretty' (/storage/strogdon/gentoo-rap/usr/lib/python3.7/site-packages/IPython/lib/pretty.py)

This is probably one of many problems.

kiwifb commented 4 years ago

I have stuff in the vbraun branch that I should merge now. Works with ipython-7.5. There is just some specific doctests that fail that shouldn't. See trac above. I'll merge shortly.

kiwifb commented 4 years ago

Merged, so you can try stuff now. I haven't tested ipython-7.10 but it should build.

strogdon commented 4 years ago

Builds here with ipython-7.10.0.

ngg commented 4 years ago

Thanks for the quick fix! For me it works with ipython 7.5.0 (installed from gentoo) and also with ipython 7.13.0 (installed with pip)

strogdon commented 4 years ago

Probably not unexpected, but I have a HUGE number of doctest failures.

kiwifb commented 4 years ago

Yes, with ipython-7.10+ all doctests involving a dictionary will fail, or almost. See quoted sage ticket.