Unable to build vanilla 9.8.rc0

[strogdon]

This must be due to a system component. I was having issues so I did a make distclean && make doc-clean before make doc-pdf.

    running build_ext
    building 'sage.rings.polynomial.multi_polynomial_libsingular' extension
    INFO: C compiler: gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -O2 -fPIC

    INFO: compile options: '-Isage/cpython -I/usr/include/singular -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/cysignals -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/cypari2 -Isage/rings/finite_rings -Isage/libs/ntl -I/local/sage-git/sage/src -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/numpy/core/include -I/usr/include/python3.10 -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/include -I/usr/include/python3.10 -c'
    extra options: '-std=c++11'
    INFO: gcc: sage/rings/polynomial/multi_polynomial_libsingular.cpp
    sage/rings/polynomial/multi_polynomial_libsingular.cpp: In function ‘PyObject* __pyx_pf_4sage_5rings_10polynomial_28multi_polynomial_libsingular_23MPolynomial_libsingular_106lift(__pyx_obj_4sage_5rings_10polynomial_28multi_polynomial_libsingular_MPolynomial_libsingular*, PyObject*)’:
    sage/rings/polynomial/multi_polynomial_libsingular.cpp:35140:120: error: ‘pTakeOutComp1’ was not declared in this scope; did you mean ‘pTakeOutComp’?
    35140 |       __pyx_t_1 = ((PyObject *)__pyx_f_4sage_5rings_10polynomial_28multi_polynomial_libsingular_new_MP(__pyx_v_parent, pTakeOutComp1((&(__pyx_v_res->m[__pyx_v_i])), __pyx_v_j))); if (unlikely(!__pyx_t_1)) __PYX_ERR(0, 4573, __pyx_L1_error)
          |                                                                                                                        ^~~~~~~~~~~~~
          |                                                                                                                        pTakeOutComp
    error: Command "gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -O2 -fPIC -Isage/cpython -I/usr/include/singular -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/cysignals -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/cypari2 -Isage/rings/finite_rings -Isage/libs/ntl -I/local/sage-git/sage/src -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/numpy/core/include -I/usr/include/python3.10 -I/local/sage-git/sage/local/var/lib/sage/venv-python3.10/include -I/usr/include/python3.10 -c sage/rings/polynomial/multi_polynomial_libsingular.cpp -o build/temp.linux-x86_64-cpython-310/sage/rings/polynomial/multi_polynomial_libsingular.o -std=c++11" failed with exit status 1
    error: subprocess-exited-with-error

    × python setup.py develop did not run successfully.
    │ exit code: 1
    ╰─> See above for output.

    note: This error originates from a subprocess, and is likely not a problem with pip.
    full command: /local/sage-git/sage/local/var/lib/sage/venv-python3.10/bin/python3 -c '
    exec(compile('"'"''"'"''"'"'
    # This is <pip-setuptools-caller> -- a caller that pip uses to run setup.py
    #
    # - It imports setuptools before invoking setup.py, to enable projects that directly
    #   import from `distutils.core` to work with newer packaging standards.
    # - It provides a clear error message when setuptools is not installed.
    # - It sets `sys.argv[0]` to the underlying `setup.py`, when invoking `setup.py` so
    #   setuptools doesn'"'"'t think the script is `-c`. This avoids the following warning:
    #     manifest_maker: standard file '"'"'-c'"'"' not found".
    # - It generates a shim setup.py, for handling setup.cfg-only projects.
    import os, sys, tokenize

    try:
        import setuptools
    except ImportError as error:
        print(
            "ERROR: Can not execute `setup.py` since setuptools is not available in "
            "the build environment.",
            file=sys.stderr,
        )
        sys.exit(1)

    __file__ = %r
    sys.argv[0] = __file__

    if os.path.exists(__file__):
        filename = __file__
        with tokenize.open(__file__) as f:
            setup_py_code = f.read()
    else:
        filename = "<auto-generated setuptools caller>"
        setup_py_code = "from setuptools import setup; setup()"

    exec(compile(setup_py_code, filename, "exec"))
    '"'"''"'"''"'"' % ('"'"'/local/sage-git/sage/src/setup.py'"'"',), "<pip-setuptools-caller>", "exec"))' --no-user-cfg develop --no-deps
    cwd: /local/sage-git/sage/src/
error: subprocess-exited-with-error

Any ideas? Is something up with the system singular which is being used here?

[kiwifb]

I patched sage-9999 to use the latest singular, but it did not make into vanilla. So vanilla cannot use your system singular-4.3.1_p3.

[strogdon]

I thought maybe that was the issue.

[strogdon]

It appears that vanilla does not have an appropriate check for whether to use system singular.

configure:44348: $PKG_CONFIG --exists --print-errors "Singular >= 4.2.1"
configure:44351: $? = 0
configure:44365: $PKG_CONFIG --exists --print-errors "Singular >= 4.2.1"
configure:44368: $? = 0
configure:44410: result: yes

[strogdon]

Forgot the next line

configure:44559: will use system package and not install SPKG singular

[strogdon]

The relevant upgrade ticket is positive, so hopefully with next rc. Off topic, are you able to login to trac?

[kiwifb]

Cannot login to trac. That's not unexpected, there was an announcement that it would be offline during migration work to github. May take some more time before it is open again.

[strogdon]

This is s-o-g specific and will probably not impact anyone. Vanilla can be built with ./configure --with-system-singular=no