search

csci3251-2020 / project-team-c

project-team-c created by GitHub Classroom
0 stars 4 forks source link

Add 1155125129.md #10

Closed wcchan9 closed 4 years ago

wcchan9 commented 4 years ago

Add self intro

wcchan9 commented 4 years ago

could someone please help me merge to the master branch? thanks a lot @Jenny-Ch @AaaaronNg

Vectorial1024 commented 4 years ago

What I see from my side is "Merging is blocked: the base branch requires all commits to be signed."

While there are ways to sign commits locally, it seems the simplest way to avoid this error is to make changes on GitHub.com in our web browsers, and not use any other method (e.g. GitHub Desktop). AFAIK, commits made via web browsers are always signed.

Unfortunately this means that this Merge Request has to be redone so to meet the "signed" requirements. But fortunately the commit is small enough that it is not too problematic to redo.

Jenny-Ch commented 4 years ago

me too

Jenny-Ch commented 4 years ago

So may be u create a new pull request?

Vectorial1024 commented 4 years ago

Done. We should all make changes on web browsers in the future.

Please refer to #17 instead.

@wcchan9 please close this when you are ready.