search

cscorley / whatthepatch

What The Patch!? -- A Python patch parsing library
MIT License
64 stars 24 forks source link

Replace nose with pytest #37

Closed MeggyCal closed 4 years ago

MeggyCal commented 4 years ago

On Python 3.9 or 3.10 nose will stop working, so let us transform the tests to pytest.

Sorry, I do not know how to purge nose from Pipfile.lock, could you please do it yourself?

MeggyCal commented 4 years ago

Now I made it to run at least on ubuntu and macos. How do I set the PYTHONPATH on Windows, please?

cscorley commented 4 years ago

Hello,

Thank you so much for this change!

Instead of PYTHONPATH=, I think the preferred method is to run pytest directly in GitHub actions, according to this document: https://docs.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#testing-your-code

For my personal dev, I use pipenv: https://pipenv.pypa.io/en/latest/. I would ordinarily uninstall nose with pipenv uninstall nose, and then install pytest with pipenv install pytest --dev. I can fix pipenv after your changes :) It is not required by the build or publish.