search

cscott / compressjs

Pure JavaScript de/compression (bzip2, etc) for node.js, volo, and the browser.
GNU General Public License v2.0
352 stars 41 forks source link

Help needed for contribution #22

Closed upupming closed 5 years ago

upupming commented 5 years ago

Hi, I have created a new project arithmetic-coding and finished the implementation. But now the biggest problem is to read/write to files, the speed is so slow. I'm going to find another method for reading/writing files.

As shown in travis build log, my algorithm takes 1357ms to encode and decode a 61,357B file.

And so I find your project! I have a few questions now:

  1. Is it okay for me to add my arithmetic coding algorithm to your project?
  2. Also, should I reuse https://github.com/cscott/compressjs/blob/master/lib/Stream.js
  3. Should I keep it a single project or integrate to this project directly?

Thanks for your patience in advance!

cscott commented 5 years ago

It's fine to build on my work! I'd recommend forking my project on GitHub and working on your contribution there. When it's done we can talk about whether to merge the changes back into my repository, release it as a separate npm package or what. I'm not actively maintaining compressjs these days so it may make more sense to release your work as a separate package but we don't have to decide that now. --scott

On Fri, Mar 29, 2019, 8:11 AM Li Yiming notifications@github.com wrote:

Hi, I have created a new project arithmetic-coding https://github.com/upupming/arithmetic-coding and finished the implementation. But now the biggest problem is to read/write to files, the speed is so slow. I'm going to find another method for reading/writing files.

And so I find your project! I have a few questions now:

  1. Is it okay for me to add my arithmetic coding algorithm to your project?
  2. Also, should I reuse https://github.com/cscott/compressjs/blob/master/lib/Stream.js
  3. Should I keep it a single project or integrate to this project directly?

Thanks for your patience in advance!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cscott/compressjs/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJhsAy0dVTHigsVSzf0LGowy7ZHrAjrks5vbgMMgaJpZM4cSQde .

upupming commented 5 years ago

Thanks for quick response and I will work on it this weekend.

upupming commented 5 years ago

Closed as I have opened a PR #23.