search

csdaw / ggprism

ggplot2 extension inspired by GraphPad Prism
https://csdaw.github.io/ggprism/
169 stars 21 forks source link

Issues with next version of ggplot2 #20

Open thomasp85 opened 1 year ago

thomasp85 commented 1 year ago

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that your package somehow includes references to ggplot2 code from when it was build, either by reloading saved plot objects or by grabbing functions at build time. Please see https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/ for some more info about why this can cause issues.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards Thomas

BramVDBe commented 1 year ago

@csdaw @actions-user Is this a critical thing? I would be sad to see ggprism outdated for future ggplot versions.

csdaw commented 1 year ago

Thanks for the bump!

The guide_prism functions currently rely on some non-exported functions from ggplot2 which is not advisable. I'll try and fix this similar to teunbrand/ggh4x@ddd2a36.