search

csdl / makahiki

An Open Source "Serious Game" Framework for Sustainability
http://makahiki.readthedocs.org/
MIT License
7 stars 5 forks source link

SGG unreachable checker report error when the unlock condition for action does not depends on other action #593

Open yongwen opened 10 years ago

yongwen commented 10 years ago

The checker is too restrict that it only allow the unlock condition to depend on other actions.

The condition "submitted_some_of" and "unlock_on_date" do not have any dependency on a specific action, the unreachable checker returns error.

The example is one event has the following unlock predicate: submitted_some_of_level(1, 3) or unlock_on_date("2014-01-26")

yongwen commented 10 years ago

the workaround is to temporary turn off the "unreachable check" in the checker settings

cammoore commented 10 years ago

There is no such predicate as "submitted_some_of" you have to add _level, or _resource or _type. The checker should return true for "unlock_on_date" no matter what the date is. I'll have to look into this.

On Sun, Jan 26, 2014 at 12:22 AM, Yongwen Xu notifications@github.comwrote:

the workaround is to temporary turn off the "unreachable check" in the checker settings

— Reply to this email directly or view it on GitHubhttps://github.com/csdl/makahiki/issues/593#issuecomment-33313593 .