search

csdms-contrib / slepian_alpha

Scalar spherical-harmonic analysis and Slepian functions
GNU General Public License v2.0
26 stars 31 forks source link

Replace Matlabpool with Parpool #12

Closed maxvonhippel closed 6 years ago

maxvonhippel commented 6 years ago

Matlabpool has been deprecated. This PR is fairly trivial; it replaces instances of Matlabpool in Slepian_Alpha with Parpool, the replacement Matlab created to/for Matlabpool.

harig00 commented 6 years ago

Parallel pools are automatic now also. If you call a parfor loop without a pool open it will open one automatically. So its probably better to just remove these calls and let it do it automatically once per session.

maxvonhippel commented 6 years ago

@harig00 I think where it makes sense to keep the calls would be when we are deciding between using the parallel version or the non parallel version of a script, when two such versions exist. For example, here. Or in the future if we write any scripts which explicitly use specific profiles with parpool (no such code exists currently that I am aware of in Slepian, but it seems possible for some niche use case in the future).