csdms / babelizer

Transform BMI-wrapped models into Python packages
https://babelizer.readthedocs.io
MIT License
4 stars 3 forks source link

Revert "Change name of metadata directory" #36

Closed mdpiper closed 3 years ago

mdpiper commented 3 years ago

This reverts commit 88220cf40562bbc9a8b9b7f686e3c6697f8cc184, which fixes #35.

This statement gives the location of the installed model metadata. Changing it here in the babelizer causes problems downstream--it confuses the model_metadata package, which raises an exception from within pymt. I didn't fully understand the consequences of this change when I made it.

mcflugen commented 3 years ago

@mdpiper sorry, I should have caught this.

As part of this pull request, would it be possible for you to add a test that checks that metadata files are installed correctly?

mdpiper commented 3 years ago

@mcflugen I shouldn't have messed up! I'll make a test.

mdpiper commented 3 years ago

@mcflugen Added test code. It's ugly, though; any suggestions for improvement are welcome.