csdms / babelizer

Transform BMI-wrapped models into Python packages
https://babelizer.readthedocs.io
MIT License
4 stars 3 forks source link

[JOSS Review] Supported Python versions #62

Closed cheginit closed 2 years ago

cheginit commented 3 years ago

Although in README the supported Python version is stated as >=3.8 but in the setup.py or setup.cfg and the conda-forge recipe, the required fields are not specified. This could potentially lead to issues when installing the package with other Python packages that may not support Python 3.8+ versions.

For setup.py or setup.cfg the field is python_requires='>3.8' and for conda-forge recipe, i.e., meta.yml file, - python >= 3.8 should be specified in both host and run sections.

This issue is related to openjournals/joss-reviews#3344

cheginit commented 3 years ago

I just noticed that bmi-tester does not support Python 3.10 so you might want to note that Python 3.10 is not supported. At least for development purposes.