search

csdms / babelizer

Transform BMI-wrapped models into Python packages
https://babelizer.readthedocs.io
MIT License
4 stars 3 forks source link

Add python 3.8 to the ci tests #72

Closed mcflugen closed 2 years ago

mcflugen commented 2 years ago

This pull request add Python 3.8 to our continuous integration tests.

mdpiper commented 2 years ago

I've seen this before. ld is looking in the wrong place. These libraries are included in the conda environment.

mcflugen commented 2 years ago

I've seen this before

Thanks @mdpiper. It looks like the problem is that, because we use pyproject.toml, pip installs the build system using packages (i.e. setuptools, in particular) from PyPI but these packages are incompatible with the conda compilers--according to Stack Overflow, anyway.

mcflugen commented 2 years ago

Looks like that did the trick.

mdpiper commented 2 years ago

Awesome! Good sleuthing, @mcflugen.

mcflugen commented 2 years ago

@mdpiper Should we add user documentation about this?

mdpiper commented 2 years ago

@mcflugen I feel this is an edge case, and I'd rather not have docs on it that will soon become stale. Why don't we flag this in an issue? This way we have a record of it and we can address it if it becomes a problem.

mcflugen commented 2 years ago

@mdpiper that sounds like a marvelous solution!