Update how grids work in Bmi, BmiHeat classes

csdms / bmi-example-python

An example of wrapping a model written in Python with a BMI

https://bmi.csdms.io

MIT License

13 stars 22 forks source link

Update how grids work in Bmi, BmiHeat classes #2

Closed mdpiper closed 9 years ago

mdpiper commented 9 years ago

Items in this pull request:

implemented the get_var_grid method for BmiHeat
made all get_grid_* methods accept a grid id, instead of a long variable name
updated unit tests
added new unit tests

Note that we're allowing the get_grid_* methods to raise a KeyError when an invalid grid id is passed. The caller will have to handle this error.

coveralls commented 9 years ago

Coverage decreased (-0.3%) to 99.7% when pulling 12966892ea848990664c5c6566c43a3dbba436b9 on mdpiper:master into d8c700d9ee65d0af9715da736cf82622b1276dd6 on csdms:master.

landscape-bot commented 9 years ago

Repository health decreased by 0.43% when pulling 1296689 on mdpiper:master into d8c700d on csdms:master.

2 new problems were found (including 0 errors and 2 code smells).
1 problem was fixed (including 0 errors and 1 code smell).

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 04cf397c289017f33e96d6f70139d5082a5f2365 on mdpiper:master into d8c700d9ee65d0af9715da736cf82622b1276dd6 on csdms:master.

landscape-bot commented 9 years ago

Repository health decreased by 0.04% when pulling 04cf397 on mdpiper:master into d8c700d on csdms:master.

1 new problem was found (including 0 errors and 1 code smell).
1 problem was fixed (including 0 errors and 1 code smell).