search

csdms / bmi

The Basic Model Interface is a standardized set of functions allowing coupling of models to models and models to data
https://bmi.readthedocs.io
MIT License
49 stars 17 forks source link

CI failure due to deprecation warning on docs #124

Closed PhilMiller closed 1 year ago

PhilMiller commented 1 year ago

WARNING: The pre-Sphinx 1.0 'intersphinx_mapping' format is deprecated and will be removed in Sphinx 8. Update to the current format as described in the documentation. Hint: "intersphinx_mapping = {'<name>': ('https://docs.python.org/', None)}".https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping

Originally posted by @PhilMiller in https://github.com/csdms/bmi/issues/123#issuecomment-1591996725

mdpiper commented 1 year ago

Fixed with #122.

PhilMiller commented 1 year ago

Oh, I see. Thank you.

Should fresh PRs (e.g. #123) generally be targeting stable rather than develop? Or is there some process by which those changes get merged over? I didn't see anything about preferred branch or such in the contributing guidelines.

mdpiper commented 1 year ago

@PhilMiller I've been adding minor changes to stable, then manually merging stable into develop. Structural changes, or changes to the BMI itself, go to develop. No docs on this; we're pretty low-volume (interfaces don't like to change!), but @mcflugen or I can communicate with people on issues or PRs.

PhilMiller commented 1 year ago

Ok. I've rebased #123 on stable and re-targeted the PR there. I'll leave the merge to develop to you