search

csdms / pymt

A Python toolkit for running and coupling Earth surface models
https://pymt.readthedocs.io
MIT License
52 stars 20 forks source link

Install cfunits xml data #113

Closed mcflugen closed 4 years ago

mcflugen commented 4 years ago

This pull request installs the pymt-embedded cfunits xml data files with the package. Without these data files, cfunits would report an error about Sverdrups (Sv).

Traceback (most recent call last):
...
    assert 0 == _ut_unmap_symbol_to_unit(_ut_system, _c_char_p(b"Sv"), _UT_ASCII)
AssertionError

I've also fixed on SyntaxWarnings with cfunits that warned about using is with literal comparisons rather than ==.

mdpiper commented 4 years ago

@mcflugen Thanks for fixing this!

mdpiper commented 4 years ago

@mcflugen Do you want to merge this so @gantian127 can rebase her notebook branch on it?