Tian fix demo notebooks

csdms / pymt

A Python toolkit for running and coupling Earth surface models

https://pymt.readthedocs.io

MIT License

52 stars 20 forks source link

Tian fix demo notebooks #94

Closed gantian127 closed 5 years ago

gantian127 commented 5 years ago

I fixed the issue https://github.com/csdms/help-desk/issues/10 subside, sedflux3D notebooks were rerun and tested child and Sedflux3D_and_child notebooks were only updated with the code

coveralls commented 5 years ago

Coverage decreased (-1.7%) to 69.69% when pulling b1c08211e650913f09adde9965e90c4bc105c203 on tian-fix_demo_notebooks into 1d91ce1b7d60392c225e8d2059681849567b4512 on master.

mdpiper commented 5 years ago

The Appveyor build fails because of #95. (There's a possible fix with #93.)

mdpiper commented 5 years ago

@mcflugen @gantian127 I diffed this branch against master and found nothing that would decrease the coverage. Given this + the known issue with Appveyor, I think this PR is fine to merge.

At some point we should create additional tests to increase the coverage. (Perhaps you'd be interested in doing this, Tian, since it's Python, not C!)

gantian127 commented 5 years ago

@mdpiper Thanks for checking my code. I would love to learn and work on adding additional tests to increase the coverage in the future.