search

csdms / wmt-client

A GWT client for the CSDMS Web Modeling Tool
MIT License
0 stars 0 forks source link

A component cannot directly provide a uses port for itself #108

Closed mdpiper closed 7 years ago

mdpiper commented 7 years ago

The AnugaSed component both provides and uses an elevation port. This leads to the following when loading an AnugaSed instance:

The AnugaSed instance is aliased into its own elevation uses port. This makes no sense. Further, it also borks the WMT client; e.g., wmt-api throws an error when the model is saved.

The WMT client should have a check to prevent a component from directly providing a uses port for itself.

mdpiper commented 7 years ago

@mcflugen commented that this could be thought of as a pass-through. However, this is still a bug in the client.

mdpiper commented 7 years ago

I'm coming around to the notion that it's not technically wrong to have a component fill its own uses port. However, it shouldn't be done automatically. This much I can fix.