Don't hardcode driver string

csdms / wmt-client

A GWT client for the CSDMS Web Modeling Tool

MIT License

0 stars 0 forks source link

Don't hardcode driver string #119

Open mdpiper opened 6 years ago

mdpiper commented 6 years ago

In the ModelSerializer class, there are several comparisons against the string literal "driver". This is poor coding. There's an existing Constants.DRIVER parameter that should be used instead.

mdpiper commented 6 years ago

This is fixed in https://github.com/csdms/wmt-client/commit/6a42055c230ff81c57bf349b3b47b7483e037690, but it should be fixed in the master branch, as well.